adds getLanguages() for accessing the language map#6768
adds getLanguages() for accessing the language map#6768BigBlueHat wants to merge 1 commit intoadobe:masterfrom
Conversation
Mostly geared toward extensions that need to know the current state of the language map before they provide further features.
|
My hope is to use this in my LangMan extension. |
|
@BigBlueHat Thanks for contributing to Brackets. First, you need to agree to the Brackets CLA. Next, take a look at the Switch language / syntax mode of current document pull request to make sure you're not duplicating any effort with your extension. I think that other change is more about changing language mode for single documents where you're thinking more about changing language mode for file extensions. |
|
Hmm, exposing the full state of LanguageManager as a mutable object might be asking for trouble. @BigBlueHat maybe it'd be good to enumerate the use cases your extension is trying to handle, and which of them the existing APIs aren't able to support? |
|
If your extension just needs the list of available languages -- and can do everything else via the existing Language APIs -- then it might be enough to just offer an API that returns |
|
Haven't heard back. Closing. |
|
Oof.. For some reason I missed all the notifications about this until last night. 😦 Sorry about that. @peterflynn the #6409 pull request includes code that is equivalent to my patch: brackets/src/language/LanguageManager.js Lines 241 to 248 in 6c34d70 So, no worries on including this commit in itself. The LangMan extension is meant to eventually offer a UI that lets one associate "random" file extensions with supported languages. I need to learn more about Brackets before I flesh it out. The I'll watch #6409 and try to get LangMan done following that. Thanks @redmunds for cleaning house. 😉 |
|
Re-opening. |
|
Re-Closing. This will get merged in #6409. |
Mostly geared toward extensions that need to
know the current state of the language map
before they provide further features.
@redmunds I blame you for this. 😉