[CLOSED] adds getLanguages() for accessing the language map

[core-ai-bot]

Issue by BigBlueHat
Wednesday Feb 05, 2014 at 19:21 GMT
Originally opened as adobe/brackets#6768

---

Mostly geared toward extensions that need to
know the current state of the language map
before they provide further features.

@redmunds I blame you for this. 😉

---

BigBlueHat included the following code: https://github.com/adobe/brackets/pull/6768/commits

[core-ai-bot]

Comment by BigBlueHat
Wednesday Feb 05, 2014 at 19:25 GMT

---

My hope is to use this in my LangMan extension.

[core-ai-bot]

Comment by redmunds
Wednesday Feb 05, 2014 at 20:29 GMT

---

@BigBlueHat Thanks for contributing to Brackets. First, you need to agree to the Brackets CLA.

Next, take a look at the Switch language / syntax mode of current document pull request to make sure you're not duplicating any effort with your extension. I think that other change is more about changing language mode for single documents where you're thinking more about changing language mode for file extensions.

[core-ai-bot]

Comment by peterflynn
Friday Feb 07, 2014 at 19:53 GMT

---

Hmm, exposing the full state of LanguageManager as a mutable object might be asking for trouble. @BigBlueHat maybe it'd be good to enumerate the use cases your extension is trying to handle, and which of them the existing APIs aren't able to support?

[core-ai-bot]

Comment by peterflynn
Friday Feb 07, 2014 at 19:54 GMT

---

If your extension just needs the list of available languages -- and can do everything else via the existing Language APIs -- then it might be enough to just offer an API that returns Object.keys(_languages)...

[core-ai-bot]

Comment by redmunds
Tuesday Mar 25, 2014 at 00:40 GMT

---

Haven't heard back. Closing.

[core-ai-bot]

Comment by BigBlueHat
Tuesday Mar 25, 2014 at 12:42 GMT

---

Oof.. For some reason I missed all the notifications about this until last night. 😦 Sorry about that.

@peterflynn the #6409 pull request includes code that is equivalent to my patch:
https://github.com/adobe/brackets/blob/6c34d70b45b4172095301c8227335c11b511998b/src/language/LanguageManager.js#L241-L248

So, no worries on including this commit in itself.

The LangMan extension is meant to eventually offer a UI that lets one associate "random" file extensions with supported languages. I need to learn more about Brackets before I flesh it out. The .getLanguages need was just the first impasse I hit.

I'll watch #6409 and try to get LangMan done following that.

Thanks@redmunds for cleaning house. 😉

[core-ai-bot]

Comment by redmunds
Tuesday Mar 25, 2014 at 16:47 GMT

---

Re-opening.

[core-ai-bot]

Comment by redmunds
Tuesday Mar 25, 2014 at 22:03 GMT

---

Re-Closing. This will get merged in #6409.