New Insert Code Hints with Tab Preference#6984
Conversation
There was a problem hiding this comment.
I noticed that this isn't needed anymore with the latest API change.
|
@peterflynn @RaymondLim Ready for re-review/merge :) |
|
Sure, I'll merge in a few minutes after I verify with your branch. |
|
Cool, thanks |
New Insert Code Hints with Tab Preference
There was a problem hiding this comment.
@TomMalbran @RaymondLim Note: APIs should be deprecated first, and not removed for a few releases to give extension authors time to fix or remove their extensions.
There was a problem hiding this comment.
See #6984 (comment):
Or it might be reasonable to just deprecate or remove this API. Afaik there's only one extension that uses it, and it would be basically obsoleted by the new preference anyway.
There was a problem hiding this comment.
Well, that 1 extension wasn't updated. If it was communicated somewhere this user didn't read or understand it. Also some people write extension that are only used privately (i.e. they are not posted to public exchange), so we can't know how many extensions use the API call.
5 participants
Just added this new Preference using the existing code.
@iwehrman extension should still work.