Improvements to Close Others

[marcelgerber]

As mentioned in #6020 (comment), I just did some improvements to the Close Others extension:

• Removed the DocumentCommandHandlers module - it wasn't used
• Renamed modules (beginning with an uppercase char) and vars (camelCase) to match the Brackets standard
• Using the handler beforeContextMenuOpen

Unit tests still passing.
@JeffryBooher

[marcelgerber]

I thought about either removing these parts (settings) completely or replacing them with the new preferences system, but I wanted to hear your opinion first.

[TomMalbran]

I was thinking the same. I think it might be cool to use the preference system, since this settings seem hard to edit.

[marcelgerber]

I just added another commit to address these nits and use the PreferencesManager instead of the settings file.
It works, but I don't think it's the best solution. Could you take another look?

[TomMalbran]

I don't think that we need an additional enabled pref. It doesn't make much sense to have the menu items, but the commands disabled. If you want to disable them, you can just disable all the other menus.

[marcelgerber]

It shouldn't ever happen to have the menu entries but not the commands (we need the commands to register menu entries). I added this pref to make disabling the whole thing easier.
But I can remove it if you want me to.

[TomMalbran]

Right... i still think is not needed since is just 3 preference to mark as false, which is not that much code:

{
    "closeAbove": false,
    "closeBelow": false,
    "closeOthers": false
}

[TomMalbran]

Actually it is:

{
    "closeOthers.closeAbove": false,
    "closeOthers.closeBelow": false,
    "closeOthers.closeOthers": false
}

Do you think like this it might be better?

{
    "closeOthers.above": false,
    "closeOthers.below": false,
    "closeOthers.others": false
}

[marcelgerber]

Yes, that's better. Changed, thanks.

[marcelgerber]

Adressed all comments.

[TomMalbran]

It looks good. Will wait and see if @JeffryBooher has any input for this.

[JeffryBooher]

Looks good to me...merging