[CLOSED] Improvements to Close Others

[core-ai-bot]

Issue by MarcelGerber
Friday Feb 28, 2014 at 20:06 GMT
Originally opened as adobe/brackets#7038

---

As mentioned in adobe/brackets#6020 (comment), I just did some improvements to the Close Others extension:

• Removed the DocumentCommandHandlers module - it wasn't used
• Renamed modules (beginning with an uppercase char) and vars (camelCase) to match the Brackets standard
• Using the handler beforeContextMenuOpen

Unit tests still passing.
@JeffryBooher

---

MarcelGerber included the following code: https://github.com/adobe/brackets/pull/7038/commits

[core-ai-bot]

Comment by MarcelGerber
Saturday Mar 01, 2014 at 17:51 GMT

---

I just added another commit to address these nits and use the PreferencesManager instead of the settings file.
It works, but I don't think it's the best solution. Could you take another look?

[core-ai-bot]

Comment by MarcelGerber
Saturday Mar 01, 2014 at 23:05 GMT

---

Adressed all comments.

[core-ai-bot]

Comment by TomMalbran
Saturday Mar 01, 2014 at 23:42 GMT

---

It looks good. Will wait and see if@JeffryBooher has any input for this.

[core-ai-bot]

Comment by JeffryBooher
Tuesday Mar 04, 2014 at 00:02 GMT

---

Looks good to me...merging