Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

[cmv4] Preserve multiple selections when saving new document or doing save as#7104

Merged
redmunds merged 1 commit intocmv4from
nj/cmv4-save-as-sel
Mar 6, 2014
Merged

[cmv4] Preserve multiple selections when saving new document or doing save as#7104
redmunds merged 1 commit intocmv4from
nj/cmv4-save-as-sel

Conversation

@njx
Copy link
Copy Markdown

@njx njx commented Mar 6, 2014

Noticed this bug randomly. @redmunds - trivial fix.

@njx
Copy link
Copy Markdown
Author

njx commented Mar 6, 2014

BTW, I did a scrub through the code base for all calls to getSelection() and getCursorPos(). Other than this one and another case in Quick Open which I have a separate bugfix for (for #6965), all other calls to these APIs should be correct given the current state of the world:

  • inline editors only deal with the primary selection
  • some functions like find use the current cursor position to start searches
  • code hints only use the primary cursor

So, overall, I think we've got all the places in the code that need to handle multiple selections, aside from this one.

@redmunds
Copy link
Copy Markdown
Contributor

redmunds commented Mar 6, 2014

Merging.

redmunds added a commit that referenced this pull request Mar 6, 2014
[cmv4] Preserve multiple selections when saving new document or doing save as
@redmunds redmunds merged commit 3ffdf0a into cmv4 Mar 6, 2014
@redmunds redmunds deleted the nj/cmv4-save-as-sel branch March 6, 2014 20:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants