Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Fix several problems with Jump to Definition API#7226

Merged
ingorichter merged 1 commit intomasterfrom
pflynn/jump-to-def-fixes
Mar 20, 2014
Merged

Fix several problems with Jump to Definition API#7226
ingorichter merged 1 commit intomasterfrom
pflynn/jump-to-def-fixes

Conversation

@peterflynn
Copy link
Copy Markdown
Member

Fix bug #7065/#5773 and other several problems with the Jump to Definition extensibility API:

  • JS impl would always crash on non-JS code, blocking any other provider from responding
  • Provider was not called with the args the docs described
  • Other errors in docs

- JS impl would always crash on non-JS code, blocking any other provider
from responding
- Provider was not called with the args the docs described
- Other errors in docs
@peterflynn peterflynn changed the title Fix bug several problems with Jump to Definition API Fix several problems with Jump to Definition API Mar 18, 2014
@ingorichter ingorichter self-assigned this Mar 18, 2014
@ingorichter
Copy link
Copy Markdown
Contributor

Looks good to me and the Exception doesn't occur anymore. Merged.

ingorichter added a commit that referenced this pull request Mar 20, 2014
Fix several problems with Jump to Definition API
@ingorichter ingorichter merged commit e75f444 into master Mar 20, 2014
@TomMalbran TomMalbran deleted the pflynn/jump-to-def-fixes branch March 20, 2014 01:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants