This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Empty pref file is an empty object, not an error.#7263
Merged
Conversation
Member
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
Yes, I think the waitsForDone() is enough, so the fail() should be removed.
Contributor
Author
There was a problem hiding this comment.
Good point. I'll remove that.
Contributor
|
Done with review. |
Contributor
Author
|
Fixed my silliness. |
Contributor
|
Merging. |
redmunds
added a commit
that referenced
this pull request
Mar 21, 2014
Empty pref file is an empty object, not an error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for #7220 (errors caused by a prefs file being empty).
This also fixes #7229 which was duped to #7220.