Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Fix EditOptionHandlers word wrap test#7291

Merged
TomMalbran merged 1 commit intomasterfrom
randy/fix-wrap-test
Mar 23, 2014
Merged

Fix EditOptionHandlers word wrap test#7291
TomMalbran merged 1 commit intomasterfrom
randy/fix-wrap-test

Conversation

@redmunds
Copy link
Copy Markdown
Contributor

This EditorOptionHandlers unit test fails for me every time:

"should also wrap long lines in inline editor by default"

Error: Expected 30 to be less than 30.
    at new jasmine.ExpectationResult (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:102:32)
    at null.toBeLessThan (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1194:29)
    at null.<anonymous> (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/spec/EditorOptionHandlers-test.js:101:45)
    at jasmine.Block.execute (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1024:15)
    at jasmine.Queue.next_ (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1842:31)
    at onComplete (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1838:18)
    at jasmine.WaitsForBlock.execute (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:2322:5)
    at file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:2336:12

I seem to be the only one seeing this. I think it has something to do with the combination of:

  • My new Windows HiDPI laptop (1920x1200)
  • Recent change where test windows no longer inherit user options (i.e. font size zoom)
  • Test windows seem to be wider now

So, the line of code is not wrapping lines any more. I checked in a fix in PR #7289 for a similar test that no longer was scrolling horizontally.

@redmunds redmunds changed the title Fix wrap test Fix EditOptionHandlers word wrap test Mar 22, 2014
@TomMalbran
Copy link
Copy Markdown
Contributor

That test fails for me too, ever time I run them and your fix here does fix it.

I am using Windows 8.1 on a big monitor at 1920x1080. It looks like the test window is wider.

@redmunds
Copy link
Copy Markdown
Contributor Author

@TomMalbran I assigned this to you, so merge when ready.

@TomMalbran
Copy link
Copy Markdown
Contributor

Code looks good and the test is fixed. So merging

TomMalbran added a commit that referenced this pull request Mar 23, 2014
Fix EditOptionHandlers word wrap test
@TomMalbran TomMalbran merged commit d3ffd96 into master Mar 23, 2014
@TomMalbran TomMalbran deleted the randy/fix-wrap-test branch March 23, 2014 04:12
@redmunds
Copy link
Copy Markdown
Contributor Author

@TomMalbran Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants