[CLOSED] Fix EditOptionHandlers word wrap test

[core-ai-bot]

Issue by redmunds
Saturday Mar 22, 2014 at 00:23 GMT
Originally opened as adobe/brackets#7291

---

This EditorOptionHandlers unit test fails for me every time:

"should also wrap long lines in inline editor by default"

Error: Expected 30 to be less than 30.
    at new jasmine.ExpectationResult (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:102:32)
    at null.toBeLessThan (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1194:29)
    at null.<anonymous> (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/spec/EditorOptionHandlers-test.js:101:45)
    at jasmine.Block.execute (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1024:15)
    at jasmine.Queue.next_ (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1842:31)
    at onComplete (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1838:18)
    at jasmine.WaitsForBlock.execute (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:2322:5)
    at file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:2336:12

I seem to be the only one seeing this. I think it has something to do with the combination of:

• My new Windows HiDPI laptop (1920x1200)
• Recent change where test windows no longer inherit user options (i.e. font size zoom)
• Test windows seem to be wider now

So, the line of code is not wrapping lines any more. I checked in a fix in PR #7289 for a similar test that no longer was scrolling horizontally.

---

redmunds included the following code: https://github.com/adobe/brackets/pull/7291/commits

[core-ai-bot]

Comment by TomMalbran
Saturday Mar 22, 2014 at 03:27 GMT

---

That test fails for me too, ever time I run them and your fix here does fix it.

I am using Windows 8.1 on a big monitor at 1920x1080. It looks like the test window is wider.

[core-ai-bot]

Comment by redmunds
Saturday Mar 22, 2014 at 15:39 GMT

---

@TomMalbran I assigned this to you, so merge when ready.

[core-ai-bot]

Comment by TomMalbran
Sunday Mar 23, 2014 at 04:12 GMT

---

Code looks good and the test is fixed. So merging

[core-ai-bot]

Comment by redmunds
Sunday Mar 23, 2014 at 16:20 GMT

---

@TomMalbran Thanks!