This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Handle prefixed property names and nested selector in getInfoAtPos(). #7373
Merged
JeffryBooher merged 1 commit intomasterfrom Apr 1, 2014
Merged
Handle prefixed property names and nested selector in getInfoAtPos(). #7373JeffryBooher merged 1 commit intomasterfrom
JeffryBooher merged 1 commit intomasterfrom
Conversation
… Also comment out a unit test for prefixed property name since we need to update CSS code hint provider with vendor prefix.
Contributor
There was a problem hiding this comment.
Any reason not to do this now?
Contributor
Author
There was a problem hiding this comment.
It involves not only code changes in CSS hint provider extension, but also creating json files or entries for specific vendor properties. Not a quick and easy task for this sprint. And it is this user story https://trello.com/c/82j3IeJn/702-css-vendor-prefixifier that we need to schedule time for.
Contributor
|
All tests pass and the 2 issues appear to be fixed... |
JeffryBooher
added a commit
that referenced
this pull request
Apr 1, 2014
Handle prefixed property names and nested selector in getInfoAtPos().
Member
|
@RaymondLim Should we add any new tests to cover #6861 and #7314? I only see a test being removed in the diff here... |
Contributor
Author
|
We do have some unit tests for one of the issue in #6824. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issues #6861 and #7314.