Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Unit Tests: CSSUtils.getInfoAtPos() ignores prefixes#6824

Merged
RaymondLim merged 1 commit intoadobe:masterfrom
oslego:prefix
Apr 2, 2014
Merged

Unit Tests: CSSUtils.getInfoAtPos() ignores prefixes#6824
RaymondLim merged 1 commit intoadobe:masterfrom
oslego:prefix

Conversation

@oslego
Copy link
Copy Markdown
Contributor

@oslego oslego commented Feb 10, 2014

Is there any reason to ignore prefixes in CSS properties?

Any prefix-like notation is dropped (-webkit- or -xxx-) and the remainder is served as PROP_NAME. This yields false-positives for things like -xxx-transform: value.

Attached test to highlight the issue.

This is for #6861

@redmunds
Copy link
Copy Markdown
Contributor

@RaymondLim Do you know why CSSUtils ignores prefixes?

@redmunds
Copy link
Copy Markdown
Contributor

@oslego Does this cause a bug with the Shapes editor, or were you just reporting this as a Brackets bug?

@TomMalbran
Copy link
Copy Markdown
Contributor

I believe the problem is mainly with CodeMirror, since it doesn't add the prefixes to the properties. Is easy to see with the highlighting. The prefixes are always black, and the properties not.

@RaymondLim
Copy link
Copy Markdown
Contributor

@TomMalbran You're right! But we can also work around in our CSSUtils.js to collect the prefix and then pass that info to the hint providers.

@oslego
Copy link
Copy Markdown
Contributor Author

oslego commented Feb 10, 2014

It does impact the shapes editor, but it's not a critical bug. I wanted to
restrict the functionality only to non-prefixed properties for
future-proofing.

Reporting this as a generic bug, which may influence future extensions.

On Monday, February 10, 2014, Randy Edmunds notifications@github.com
wrote:

@oslego https://github.com/oslego Does this cause a bug with the Shapes
editor, or were you just reporting this as a Brackets bug?

Reply to this email directly or view it on GitHubhttps://github.com//pull/6824#issuecomment-34667113
.

@RaymondLim
Copy link
Copy Markdown
Contributor

Reassign it to me.

@RaymondLim
Copy link
Copy Markdown
Contributor

Looks good. Merging.

RaymondLim added a commit that referenced this pull request Apr 2, 2014
Unit Tests: CSSUtils.getInfoAtPos() ignores prefixes
@RaymondLim RaymondLim merged commit fd59d72 into adobe:master Apr 2, 2014
@oslego oslego deleted the prefix branch April 2, 2014 13:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants