[CLOSED] Unit Tests: CSSUtils.getInfoAtPos() ignores prefixes

[core-ai-bot]

Issue by oslego
Monday Feb 10, 2014 at 15:42 GMT
Originally opened as adobe/brackets#6824

---

Is there any reason to ignore prefixes in CSS properties?

Any prefix-like notation is dropped (-webkit- or -xxx-) and the remainder is served as PROP_NAME. This yields false-positives for things like -xxx-transform: value.

Attached test to highlight the issue.

This is for #6861

---

oslego included the following code: https://github.com/adobe/brackets/pull/6824/commits

[core-ai-bot]

Comment by redmunds
Monday Feb 10, 2014 at 18:37 GMT

---

@RaymondLim Do you know why CSSUtils ignores prefixes?

[core-ai-bot]

Comment by redmunds
Monday Feb 10, 2014 at 18:54 GMT

---

@oslego Does this cause a bug with the Shapes editor, or were you just reporting this as a Brackets bug?

[core-ai-bot]

Comment by TomMalbran
Monday Feb 10, 2014 at 19:08 GMT

---

I believe the problem is mainly with CodeMirror, since it doesn't add the prefixes to the properties. Is easy to see with the highlighting. The prefixes are always black, and the properties not.

[core-ai-bot]

Comment by RaymondLim
Monday Feb 10, 2014 at 19:15 GMT

---

@TomMalbran You're right! But we can also work around in our CSSUtils.js to collect the prefix and then pass that info to the hint providers.

[core-ai-bot]

Comment by oslego
Monday Feb 10, 2014 at 19:41 GMT

---

It does impact the shapes editor, but it's not a critical bug. I wanted to
restrict the functionality only to non-prefixed properties for
future-proofing.

Reporting this as a generic bug, which may influence future extensions.

On Monday, February 10, 2014, Randy Edmunds notifications@github.com
wrote:

@oslego https://github.com/oslego Does this cause a bug with the Shapes
editor, or were you just reporting this as a Brackets bug?

Reply to this email directly or view it on GitHubhttps://github.com/adobe/brackets/pull/6824#issuecomment-34667113
.

[core-ai-bot]

Comment by RaymondLim
Wednesday Apr 02, 2014 at 00:34 GMT

---

Reassign it to me.

[core-ai-bot]

Comment by RaymondLim
Wednesday Apr 02, 2014 at 03:28 GMT

---

Looks good. Merging.