This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Fix bug #7402 (Focus not set to inline editor after creating new rule)#7419
Merged
Fix bug #7402 (Focus not set to inline editor after creating new rule)#7419
Conversation
…) - If the client of the DropdownButton changes focus in respond to the "select" event that closes it, leave focus in that new location. Only restore focus to where it was before dropdown closed if no one has touched the focus while closing.
|
I don't think this needs to be in Sprint 38. |
|
...although it seems pretty harmless :) Let me look at it. |
|
LGTM. |
njx
pushed a commit
that referenced
this pull request
Apr 5, 2014
Fix bug #7402 (Focus not set to inline editor after creating new rule)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug #7402 -- If the client of the DropdownButton changes focus in response to the
"select"event that closes it, leave focus in that new location. Only restore focus to where it was before the dropdown was opened if no one has touched the focus while it's closing.You can test the case where it is supposed to restore focus by commenting out the body of
CSSInlineEditor._onDropdownSelect()-- choosing an item from the dropdown should restore focus to the original editor in that case.@njx, up to you if you think this should go into Sprint 38 or not.