Release v2.6.4#6890
Merged
Merged
Conversation
`click` released v8.2 breaking the API so we to pin to`~=8.1.0` Cherry-pick: e1d55fa Since most of the uv infrastructure has not been part of previous releases, the fix has been reapplied rather than cherry-picking the commit with all other commits it depends on.
`click` released v8.2.0 and by that broke the references to their doc. We pinned `click~=8.1` so we still need to reference the old API but because `click` only keeps one version of the documentation, we cannot reference a different API. Thus we reference the functions by the GitHub link for v8.1.0. Cherry-pick: 5168032
agoscinski
force-pushed
the
release/2.6.4
branch
5 times, most recently
from
1a8cc88 to
0034e94
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## support/2.6.x #6890 +/- ##
=================================================
- Coverage 77.80% 77.79% -0.00%
=================================================
Files 562 562
Lines 41846 41849 +3
=================================================
Hits 32554 32554
- Misses 9292 9295 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
agoscinski
requested review from
danielhollas and
unkcpz
and removed request for
danielhollas
danielhollas
approved these changes
May 22, 2025
Collaborator
danielhollas
left a comment
danielhollas
left a comment
There was a problem hiding this comment.
Ugh, this looks painful thanks for doing this!
|
|
||
| ### Fixes | ||
| - Dependencies: Pin click to `~=8.1.0` (#6888) [[e1d55fa]](https://github.com/aiidateam/aiida-core/commit/e1d55fa0d6c268db7a25e9740679a5a0fbe412b8) | ||
| - Fixing doc references after `click` 8.2 release (#6880) [[5168032]](https://github.com/aiidateam/aiida-core/commit/5168032b810aef94ca91c91859e53e1752c72273) |
Collaborator
There was a problem hiding this comment.
Suggested change
| - Fixing doc references after `click` 8.2 release (#6880) [[5168032]](https://github.com/aiidateam/aiida-core/commit/5168032b810aef94ca91c91859e53e1752c72273) |
Let's remove this, it's irrelevant to the readers of the changelog and does not touch code.
…iidateam#6693) `verdi devel check-undesired-imports` makes sure that we don't have heavy imports during verdi startup to keep the CLI snappy (especially for tab completion). One of the expensive modules that it checks is `asyncio`. Unfortunately, when you install the tui extra, the trogon package that powers the tui functionality seems to use asyncio, and this makes the test fail. (indeed, one of the TUIs current downsides is that it makes all CLI interactions slower, even if you don't use the TUI subcommand). The PR makes the test more clever and don't check for `asyncio` import when `tui` extras is installed. Cherry-pick: 8039ad9 some uv changes have been removed
Adding BaseModel to nitpick-exceptions. Cherry-pick: 958bfd0 Only picks up the RTD changes from the commit.
The version specifier `~=2.7,>=2.7.2` become invalid in mamba and results in the error ``` libmambapy.bindings.specs.ParseError: Error parsing version "'>=2.7.2". Version contains invalid characters in '>=2.7.2. ``` This is fixed by using the equivalent specifier `<3.0.0,>=2.7.2`
The links of the commit hashes have been fixed and the TODO has been resolved.
The readthedocs needs to specify the configuration location. This is a simplified fix of commit 15b5caf in the main branch. That cannot cherry-picked since it would require an uv update.
Collaborator
Author
|
Docker image build is failing but it was not working for any 2.6.x release and now 2-4 weeks before the release of v2.7.0 is not worth the time to fix it for this release as it is working for the next minor release and release candidate versions are already uploaded. |
agoscinski
force-pushed
the
release/2.6.4
branch
4 times, most recently
from
2d79a14 to
564067e
Compare
Collaborator
Author
|
I did a testrun of the release workflow and it worked https://github.com/agoscinski/aiida-core/actions/runs/15189282862/job/42717934704 merging now if CI passes (except codecov and docker) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release to mainly contain the fix #6888
I had to adapt the click fix #6888 to not end up in cherry-picking all devops changes as well as other new dependencies (like the updated disk-objetcstore since git also tracks this as a change due to the added comma). The added first the commits that have a corresponding commit on the main branch (most of them are highly adapted make them independent on other changes), then I added further changes that are completely disconnected from main just to make pre-commit, RTD, conda tests work. The fixes to the changelog do not have a corresponding commit in the main branch as we did the
CHANGELOG.mdthere correctly.EDIT:
Docker image build is failing but it was not working for any
2.6.xrelease and now 2-4 weeks before the release ofv2.7.0is not worth the time to fix it for this release as it is working for the next minor release and release candidate versions are already uploaded.