Skip to content
This repository was archived by the owner on Aug 27, 2022. It is now read-only.

Improve Post-Processing#290

Merged
andi34 merged 10 commits intodevfrom
improve/collage
Aug 9, 2021
Merged

Improve Post-Processing#290
andi34 merged 10 commits intodevfrom
improve/collage

Conversation

@andi34
Copy link
Copy Markdown
Owner

@andi34 andi34 commented Aug 8, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "x" next to an item)

  • Bug fixes
  • Others

What changes did you make? (Give an overview)

  • Bug fixes
    • collage:
      • always respect the time an image on continuous collage is visible (before, post-processing started without showing the last image of the collage)
      • Apply defined effect(s) and/or filter to the single images instead of the final collage
    • config:
      • temporary remove numbered image naming option

        Currently we're counting the files inside the images folder or reading
        database lenght to get the image name.
        We are not really checking for the next available number which could
        cause that we're loosing made images.

        • Example 1:
          We have 3 images: 0001.jpg, 0002.jpg and 0003.jpg
          Next image-name will be named 0004.jpg
          Everything is fine here

        • Example 2:
          We have 2 images: 0001.jpg and 0003.jpg
          Next image-name will be named 0003.jpg!
          This will override the already existing 0003.jpg!

        Since i have no quick solution, let's disable numbered image naming for now.

  • Other changes:
    • collage:
      • add "Please wait" message on continuous collage
      • remove unneeded tmp picture
      • prettier original file naming (if we like to keep original images)
    • Logging:
      • rename "gphoto logs" to "camera log"
      • Show camera log independent of dev mode
      • log issues while post-processing inside the camera log
    • api:
      • Remove unneeded file-type checks all around the Photobooth api (we check for jpeg images already inside the api/applyEffects.php)
    • lib:
      • add central camera log function

andi34 added 8 commits August 7, 2021 09:05
Change-Id: Ia71c53fb18b62181d99f622c66903af45f1b7042
Change-Id: Id501195aadd6da0fa1deb2506602c645614cb5b7
Change-Id: Ic3f0945b1eb08dd1ccfe2d653e1bcdc50143c0aa
…sible

Change-Id: I3a2188148ac03bd1a2ca132cdb693fddafdd0b3a
Change-Id: Ic4cc10b1fbbd4197b3aedb1967b370c0ed24a1c7
Change-Id: I1eca711d3b597080307193bad449e8941ea68c95
Change-Id: Iacb411dce8171885e809ef6691eb60b9d5fae323
Change-Id: Ic9ae2e7cd3b0f6082d0ba13e6faeb6dfb73af0cb
@andi34 andi34 changed the title Collage improvements Improve Post-Processing Aug 9, 2021
andi34 added 2 commits August 9, 2021 13:40
Change-Id: I1fd1e23f70daf068947bbcb275940de976d80424
Currently we're counting the files inside the images folder or reading
database lenght to get the image name.
We are not really checking for the next available number which could
cause that we're loosing made images.

- Example 1:
  We have 3 images: 0001.jpg, 0002.jpg and 0003.jpg
  Next image-name will be named 0004.jpg
  *Everything is fine here*

- Example 2:
  We have 2 images: 0001.jpg and 0003.jpg
  Next image-name will be named 0003.jpg!
  *This will override the already existing 0003.jpg!*

Since i have no quick solution, let's disable numbered image naming for now.

Change-Id: I9cf31117bc53bfc89b22c22128dd3076d5f65bde
@andi34 andi34 merged commit eaf2f53 into dev Aug 9, 2021
@andi34 andi34 deleted the improve/collage branch August 9, 2021 12:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant