This repository was archived by the owner on Aug 27, 2022. It is now read-only.
Merged
Conversation
Change-Id: Ia71c53fb18b62181d99f622c66903af45f1b7042
Change-Id: Id501195aadd6da0fa1deb2506602c645614cb5b7
Change-Id: Ic3f0945b1eb08dd1ccfe2d653e1bcdc50143c0aa
…sible Change-Id: I3a2188148ac03bd1a2ca132cdb693fddafdd0b3a
Change-Id: Ic4cc10b1fbbd4197b3aedb1967b370c0ed24a1c7
Change-Id: I1eca711d3b597080307193bad449e8941ea68c95
Change-Id: Iacb411dce8171885e809ef6691eb60b9d5fae323
Change-Id: Ic9ae2e7cd3b0f6082d0ba13e6faeb6dfb73af0cb
Change-Id: I1fd1e23f70daf068947bbcb275940de976d80424
Currently we're counting the files inside the images folder or reading database lenght to get the image name. We are not really checking for the next available number which could cause that we're loosing made images. - Example 1: We have 3 images: 0001.jpg, 0002.jpg and 0003.jpg Next image-name will be named 0004.jpg *Everything is fine here* - Example 2: We have 2 images: 0001.jpg and 0003.jpg Next image-name will be named 0003.jpg! *This will override the already existing 0003.jpg!* Since i have no quick solution, let's disable numbered image naming for now. Change-Id: I9cf31117bc53bfc89b22c22128dd3076d5f65bde
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "x" next to an item)
What changes did you make? (Give an overview)
temporary remove numbered image naming option
Currently we're counting the files inside the images folder or reading
database lenght to get the image name.
We are not really checking for the next available number which could
cause that we're loosing made images.
Example 1:
We have 3 images: 0001.jpg, 0002.jpg and 0003.jpg
Next image-name will be named 0004.jpg
Everything is fine here
Example 2:
We have 2 images: 0001.jpg and 0003.jpg
Next image-name will be named 0003.jpg!
This will override the already existing 0003.jpg!
Since i have no quick solution, let's disable numbered image naming for now.
api/applyEffects.php)