Skip to content

Validate missing chat completion model#316

Draft
brandon-behring wants to merge 1 commit into
andrewyng:mainfrom
brandon-behring:brandon/fix-model-none-validation
Draft

Validate missing chat completion model#316
brandon-behring wants to merge 1 commit into
andrewyng:mainfrom
brandon-behring:brandon/fix-model-none-validation

Conversation

@brandon-behring

Copy link
Copy Markdown

Summary

  • validate chat completion model input before checking for the provider separator
  • raise the existing invalid model format ValueError for model=None
  • add a regression test for the None model case

Fixes #254

Validation

  • uv run pytest tests/client/test_client.py tests/client/test_manual_tool_calling.py
  • uv run pre-commit run --files aisuite/client.py tests/client/test_client.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Completions.create() does not check for model=None

1 participant