Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aisuite/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ def create(self, model: str, messages: list, **kwargs):
Supports automatic tool execution when max_turns is specified.
"""
# Check that correct format is used
if ":" not in model:
if not isinstance(model, str) or ":" not in model:
raise ValueError(
f"Invalid model format. Expected 'provider:model', got '{model}'"
)
Expand Down
12 changes: 12 additions & 0 deletions tests/client/test_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,18 @@ def test_invalid_model_format_in_create():
client.chat.completions.create(invalid_model, messages=messages)


def test_none_model_format_in_create_raises_value_error():
client = Client()
messages = [
{"role": "user", "content": "Hello"},
]

with pytest.raises(
ValueError, match=r"Invalid model format. Expected 'provider:model'"
):
client.chat.completions.create(None, messages=messages)


def _chat_response(content=None, tool_calls=None):
message = Message(role="assistant", content=content, tool_calls=tool_calls)
return SimpleNamespace(choices=[SimpleNamespace(message=message)])
Expand Down