Refactor getRegistry: firstly get registry outside from lock#5484
Closed
maoyiz wants to merge 1 commit intoapache:masterfrom
maoyiz:refactor-getRegistry
Closed
Refactor getRegistry: firstly get registry outside from lock#5484maoyiz wants to merge 1 commit intoapache:masterfrom maoyiz:refactor-getRegistry
maoyiz wants to merge 1 commit intoapache:masterfrom
maoyiz:refactor-getRegistry
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5484 +/- ##
============================================
- Coverage 61.08% 61.01% -0.07%
+ Complexity 422 421 -1
============================================
Files 919 919
Lines 37502 37502
Branches 5444 5444
============================================
- Hits 22909 22883 -26
- Misses 12097 12124 +27
+ Partials 2496 2495 -1
Continue to review full report at Codecov.
|
Member
|
ping @zhaixiaoxiang |
| .removeParameters(EXPORT_KEY, REFER_KEY) | ||
| .build(); | ||
| String key = url.toServiceStringWithoutResolving(); | ||
| Registry registry = REGISTRIES.get(key); |
Member
There was a problem hiding this comment.
i think shouldn't move those code outside the lock-unlock block. it will cause invoke createRegistry multiple times in some cases.
| if (registry == null) { | ||
| throw new IllegalStateException("Can not create registry " + url); | ||
| } | ||
| REGISTRIES.put(key, registry); |
Member
There was a problem hiding this comment.
Maybe using the java.util.concurrent.ConcurrentHashMap#computeIfAbsent is the better choice ?
Contributor
There was a problem hiding this comment.
Agree. Could you please take a look? @zhaixiaoxiang
chickenlj
requested changes
Feb 2, 2020
| if (registry == null) { | ||
| throw new IllegalStateException("Can not create registry " + url); | ||
| } | ||
| REGISTRIES.put(key, registry); |
Contributor
There was a problem hiding this comment.
Agree. Could you please take a look? @zhaixiaoxiang
Contributor
|
Closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
we should get registry instance outside lock firstly, and if not null, return directly.
Brief changelog
AbstractRegistryFactory.java
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.