Refactor getRegistry: firstly get registry outside from lock #5484
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,183 +1,183 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.dubbo.registry.support; | ||
|
|
||
| import org.apache.dubbo.common.URL; | ||
| import org.apache.dubbo.common.URLBuilder; | ||
| import org.apache.dubbo.common.logger.Logger; | ||
| import org.apache.dubbo.common.logger.LoggerFactory; | ||
| import org.apache.dubbo.registry.NotifyListener; | ||
| import org.apache.dubbo.registry.Registry; | ||
| import org.apache.dubbo.registry.RegistryFactory; | ||
| import org.apache.dubbo.registry.RegistryService; | ||
|
|
||
| import java.util.Collection; | ||
| import java.util.Collections; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.concurrent.ConcurrentHashMap; | ||
| import java.util.concurrent.atomic.AtomicBoolean; | ||
| import java.util.concurrent.locks.ReentrantLock; | ||
|
|
||
| import static org.apache.dubbo.common.constants.CommonConstants.INTERFACE_KEY; | ||
| import static org.apache.dubbo.rpc.cluster.Constants.EXPORT_KEY; | ||
| import static org.apache.dubbo.rpc.cluster.Constants.REFER_KEY; | ||
|
|
||
| /** | ||
| * AbstractRegistryFactory. (SPI, Singleton, ThreadSafe) | ||
| * | ||
| * @see org.apache.dubbo.registry.RegistryFactory | ||
| */ | ||
| public abstract class AbstractRegistryFactory implements RegistryFactory { | ||
|
|
||
| // Log output | ||
| private static final Logger LOGGER = LoggerFactory.getLogger(AbstractRegistryFactory.class); | ||
|
|
||
| // The lock for the acquisition process of the registry | ||
| private static final ReentrantLock LOCK = new ReentrantLock(); | ||
|
|
||
| // Registry Collection Map<RegistryAddress, Registry> | ||
| private static final Map<String, Registry> REGISTRIES = new ConcurrentHashMap<>(); | ||
|
|
||
| private static final AtomicBoolean destroyed = new AtomicBoolean(false); | ||
|
|
||
| /** | ||
| * Get all registries | ||
| * | ||
| * @return all registries | ||
| */ | ||
| public static Collection<Registry> getRegistries() { | ||
| return Collections.unmodifiableCollection(REGISTRIES.values()); | ||
| } | ||
|
|
||
| public static Registry getRegistry(String key) { | ||
| return REGISTRIES.get(key); | ||
| } | ||
|
|
||
| /** | ||
| * Close all created registries | ||
| */ | ||
| public static void destroyAll() { | ||
| if (!destroyed.compareAndSet(false, true)) { | ||
| return; | ||
| } | ||
|
|
||
| if (LOGGER.isInfoEnabled()) { | ||
| LOGGER.info("Close all registries " + getRegistries()); | ||
| } | ||
| // Lock up the registry shutdown process | ||
| LOCK.lock(); | ||
| try { | ||
| for (Registry registry : getRegistries()) { | ||
| try { | ||
| registry.destroy(); | ||
| } catch (Throwable e) { | ||
| LOGGER.error(e.getMessage(), e); | ||
| } | ||
| } | ||
| REGISTRIES.clear(); | ||
| } finally { | ||
| // Release the lock | ||
| LOCK.unlock(); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public Registry getRegistry(URL url) { | ||
| if (destroyed.get()) { | ||
| LOGGER.warn("All registry instances have been destroyed, failed to fetch any instance. " + | ||
| "Usually, this means no need to try to do unnecessary redundant resource clearance, all registries has been taken care of."); | ||
| return DEFAULT_NOP_REGISTRY; | ||
| } | ||
|
|
||
| url = URLBuilder.from(url) | ||
| .setPath(RegistryService.class.getName()) | ||
| .addParameter(INTERFACE_KEY, RegistryService.class.getName()) | ||
| .removeParameters(EXPORT_KEY, REFER_KEY) | ||
| .build(); | ||
| String key = url.toServiceStringWithoutResolving(); | ||
| Registry registry = REGISTRIES.get(key); | ||
| if (registry != null) { | ||
| return registry; | ||
| } | ||
| // Lock the registry access process to ensure a single instance of the registry | ||
| LOCK.lock(); | ||
| try { | ||
| //create registry by spi/ioc | ||
| registry = createRegistry(url); | ||
| if (registry == null) { | ||
| throw new IllegalStateException("Can not create registry " + url); | ||
| } | ||
| REGISTRIES.put(key, registry); | ||
|
Member
There was a problem hiding this comment. Maybe using the
Contributor
There was a problem hiding this comment. Agree. Could you please take a look? @zhaixiaoxiang |
||
| return registry; | ||
| } finally { | ||
| // Release the lock | ||
| LOCK.unlock(); | ||
| } | ||
| } | ||
|
|
||
| protected abstract Registry createRegistry(URL url); | ||
|
|
||
|
|
||
| private static Registry DEFAULT_NOP_REGISTRY = new Registry() { | ||
| @Override | ||
| public URL getUrl() { | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean isAvailable() { | ||
| return false; | ||
| } | ||
|
|
||
| @Override | ||
| public void destroy() { | ||
|
|
||
| } | ||
|
|
||
| @Override | ||
| public void register(URL url) { | ||
|
|
||
| } | ||
|
|
||
| @Override | ||
| public void unregister(URL url) { | ||
|
|
||
| } | ||
|
|
||
| @Override | ||
| public void subscribe(URL url, NotifyListener listener) { | ||
|
|
||
| } | ||
|
|
||
| @Override | ||
| public void unsubscribe(URL url, NotifyListener listener) { | ||
|
|
||
| } | ||
|
|
||
| @Override | ||
| public List<URL> lookup(URL url) { | ||
| return null; | ||
| } | ||
| }; | ||
|
|
||
| // for unit test | ||
| public static void clearRegistryNotDestroy() { | ||
| REGISTRIES.clear(); | ||
| } | ||
|
|
||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think shouldn't move those code outside the lock-unlock block. it will cause invoke createRegistry multiple times in some cases.