[SPARK-53453][PYTHON][ML] Unblock 'torch<2.6.0'#52197
Closed
zhengruifeng wants to merge 6 commits intoapache:masterfrom
Closed
[SPARK-53453][PYTHON][ML] Unblock 'torch<2.6.0'#52197zhengruifeng wants to merge 6 commits intoapache:masterfrom
zhengruifeng wants to merge 6 commits intoapache:masterfrom
Conversation
LuciferYang
reviewed
Sep 2, 2025
| RUN python3.11 -m pip install --ignore-installed blinker>=1.6.2 # mlflow needs this | ||
| RUN python3.11 -m pip install $BASIC_PIP_PKGS unittest-xml-reporting $CONNECT_PIP_PKGS && \ | ||
| python3.11 -m pip install 'torch<2.6.0' torchvision --index-url https://download.pytorch.org/whl/cpu && \ | ||
| python3.11 -m pip install torch torchvision --index-url https://download.pytorch.org/whl/cpu && \ |
Contributor
There was a problem hiding this comment.
Do other Dockerfiles need to be handled in separate pr?
LuciferYang
approved these changes
Sep 2, 2025
Contributor
LuciferYang
left a comment
LuciferYang
left a comment
There was a problem hiding this comment.
The changes are fine with me.
LuciferYang
approved these changes
Sep 2, 2025
HyukjinKwon
approved these changes
Sep 2, 2025
xinrong-meng
approved these changes
Sep 2, 2025
dongjoon-hyun
approved these changes
Sep 2, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Nice. Thank you, @zhengruifeng and all.
Merged to master for Apache Spark 4.1.0.
| import torch | ||
|
|
||
| lor_torch_model = torch.load(path) | ||
| lor_torch_model = torch.load(path, weights_only=False) |
Contributor
There was a problem hiding this comment.
do we need to have the weights_only=False . From there page "Loading un-trusted checkpoint with weights_only=False MUST never be done." https://github.com/pytorch/pytorch/security
Contributor
Author
There was a problem hiding this comment.
The default value of weights_only is False in <2.6.0. And the default value was changed to True since 2.6.0.
This PR keeps the behavior.
Ideally, we should use weights_only=True, it will needs some investigation. Thanks for pointing it out.
| # test saved torch model can be loaded by pytorch solely | ||
| lor_torch_model = torch.load( | ||
| os.path.join(local_model_path, "LogisticRegressionModel.torch") | ||
| os.path.join(local_model_path, "LogisticRegressionModel.torch"), |
Contributor
There was a problem hiding this comment.
dito but this is for a tests so I think its ok.
zhengruifeng
added a commit
that referenced
this pull request
Sep 5, 2025
### What changes were proposed in this pull request? Update `dev/requirements` ### Why are the changes needed? follow up of #52197 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? ci ### Was this patch authored or co-authored using generative AI tooling? no Closes #52244 from zhengruifeng/dev_torch. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
### What changes were proposed in this pull request? Unblock 'torch<2.6.0' ### Why are the changes needed? to test with latest torch ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#52197 from zhengruifeng/torch_280. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
### What changes were proposed in this pull request? Update `dev/requirements` ### Why are the changes needed? follow up of apache#52197 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? ci ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#52244 from zhengruifeng/dev_torch. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Unblock 'torch<2.6.0'
Why are the changes needed?
to test with latest torch
Does this PR introduce any user-facing change?
No
How was this patch tested?
CI
Was this patch authored or co-authored using generative AI tooling?
No