[SPARK-55428][BUILD] Sync Netty Java options everywhere#54209
Closed
pan3793 wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-55428][BUILD] Sync Netty Java options everywhere#54209pan3793 wants to merge 1 commit intoapache:masterfrom
pan3793 wants to merge 1 commit intoapache:masterfrom
Conversation
JIRA Issue Information=== Improvement SPARK-55428 === This comment was automatically generated by GitHub Actions |
dongjoon-hyun
approved these changes
Feb 8, 2026
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM (Pending CIs)
Thank you for making this consistently, @pan3793 .
Member
|
Merged to master. |
Yicong-Huang
pushed a commit
to Yicong-Huang/spark
that referenced
this pull request
Feb 8, 2026
### What changes were proposed in this pull request? Remove redundant `-Dio.netty.tryReflectionSetAccessible=true` in some building scripts/`pom.xml` - it has already been added by `JavaModuleOptions`(`spark-submit`-based cases) or Maven property `extraJavaTestArgs`(ScalaTests/JUnit cases) Add the missing opts to `sql/connect/bin/spark-connect-scala-client` ``` -Dio.netty.allocator.type=pooled -Dio.netty.handler.ssl.defaultEndpointVerificationAlgorithm=NONE ``` ### Why are the changes needed? Keep Netty Java options sync everywhere. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GHA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#54209 from pan3793/SPARK-55428. Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
rpnkv
pushed a commit
to rpnkv/spark
that referenced
this pull request
Feb 18, 2026
### What changes were proposed in this pull request? Remove redundant `-Dio.netty.tryReflectionSetAccessible=true` in some building scripts/`pom.xml` - it has already been added by `JavaModuleOptions`(`spark-submit`-based cases) or Maven property `extraJavaTestArgs`(ScalaTests/JUnit cases) Add the missing opts to `sql/connect/bin/spark-connect-scala-client` ``` -Dio.netty.allocator.type=pooled -Dio.netty.handler.ssl.defaultEndpointVerificationAlgorithm=NONE ``` ### Why are the changes needed? Keep Netty Java options sync everywhere. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GHA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#54209 from pan3793/SPARK-55428. Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove redundant
-Dio.netty.tryReflectionSetAccessible=truein some building scripts/pom.xml- it has already been added byJavaModuleOptions(spark-submit-based cases) or Maven propertyextraJavaTestArgs(ScalaTests/JUnit cases)Add the missing opts to
sql/connect/bin/spark-connect-scala-clientWhy are the changes needed?
Keep Netty Java options sync everywhere.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GHA.
Was this patch authored or co-authored using generative AI tooling?
No.