[SPARK-56027][INFRA] Fix NoEmptyContinuation warning of spark-test-image/lint/Dockerfile#54856
Closed
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-56027][INFRA] Fix NoEmptyContinuation warning of spark-test-image/lint/Dockerfile#54856dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
NoEmptyContinuation warning of spark-test-image/lint/Dockerfile#54856dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
Conversation
dongjoon-hyun
changed the title
NoEmptyContinuation warning of spark-test-image/lint/Dockerfile`NoEmptyContinuation warning of spark-test-image/lint/Dockerfile`
dongjoon-hyun
changed the title
NoEmptyContinuation warning of spark-test-image/lint/Dockerfile`NoEmptyContinuation warning of spark-test-image/lint/Dockerfile
Member
Author
|
This is currently blocked by the following. |
dongjoon-hyun
force-pushed
the
SPARK-56027
branch
from
16610b5 to
daadb05
Compare
Member
Author
|
Could you review this a minor PR, @peter-toth ? Last night, there was an outage in CI due to new R package release. While fixing it in SPARK-56025, I found this minor annoying warning. |
peter-toth
approved these changes
Mar 17, 2026
Member
Author
|
Thank you so much, @peter-toth ! |
dongjoon-hyun
added a commit
that referenced
this pull request
Mar 17, 2026
…-image/lint/Dockerfile` ### What changes were proposed in this pull request? This PR removes a trailing backslash (`\`) on an empty continuation line in `dev/spark-test-image/lint/Dockerfile` to fix the `NoEmptyContinuation` warning from Dockerfile linters. This is the only instance of this pattern. - https://docs.docker.com/reference/build-checks/no-empty-continuation/ ### Why are the changes needed? The trailing `\` at line 69 is followed by an empty line, which triggers the `NoEmptyContinuation` warning. This is a no-op continuation that should be removed for clean lint results. ``` $ cd dev/spark-test-image/lint $ docker build . ... => WARN: NoEmptyContinuation: Empty continuation line (line 72) 0.0s ... ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Verified by searching all Dockerfiles in the repository for the backslash-followed-by-empty-line pattern and confirming this was the only occurrence. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (claude-opus-4-6) Closes #54856 from dongjoon-hyun/SPARK-56027. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 5acd8e6) Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
added a commit
that referenced
this pull request
Mar 17, 2026
…-image/lint/Dockerfile` ### What changes were proposed in this pull request? This PR removes a trailing backslash (`\`) on an empty continuation line in `dev/spark-test-image/lint/Dockerfile` to fix the `NoEmptyContinuation` warning from Dockerfile linters. This is the only instance of this pattern. - https://docs.docker.com/reference/build-checks/no-empty-continuation/ ### Why are the changes needed? The trailing `\` at line 69 is followed by an empty line, which triggers the `NoEmptyContinuation` warning. This is a no-op continuation that should be removed for clean lint results. ``` $ cd dev/spark-test-image/lint $ docker build . ... => WARN: NoEmptyContinuation: Empty continuation line (line 72) 0.0s ... ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Verified by searching all Dockerfiles in the repository for the backslash-followed-by-empty-line pattern and confirming this was the only occurrence. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (claude-opus-4-6) Closes #54856 from dongjoon-hyun/SPARK-56027. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 5acd8e6) Signed-off-by: Dongjoon Hyun <[email protected]>
Member
Author
|
Merged to master/4.1/4.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR removes a trailing backslash (
\) on an empty continuation line indev/spark-test-image/lint/Dockerfileto fix theNoEmptyContinuationwarning from Dockerfile linters. This is the only instance of this pattern.Why are the changes needed?
The trailing
\at line 69 is followed by an empty line, which triggers theNoEmptyContinuationwarning. This is a no-op continuation that should be removed for clean lint results.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Verified by searching all Dockerfiles in the repository for the backslash-followed-by-empty-line pattern and confirming this was the only occurrence.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (claude-opus-4-6)