Skip to content

[SPARK-56025][INFRA] Install remotes R package for spark-test-image/(lint|docs|sparkr)/Dockerfile#54853

Closed
dongjoon-hyun wants to merge 3 commits intoapache:masterfrom
dongjoon-hyun:SPARK-56025
Closed

[SPARK-56025][INFRA] Install remotes R package for spark-test-image/(lint|docs|sparkr)/Dockerfile#54853
dongjoon-hyun wants to merge 3 commits intoapache:masterfrom
dongjoon-hyun:SPARK-56025

Conversation

@dongjoon-hyun
Copy link
Copy Markdown
Member

@dongjoon-hyun dongjoon-hyun commented Mar 17, 2026

What changes were proposed in this pull request?

This PR aims to recover the CI by installing remotes R package for the following Dockerfiles.

  • dev/spark-test-image/lint/Dockerfile
  • dev/spark-test-image/docs/Dockerfile
  • dev/spark-test-image/sparkr/Dockerfile

Why are the changes needed?

Currently, master branch is broken due to the new devtools 2.5.0 release. This PR aims to installation remotes package explicitly because we cannot pin devtools itself.

Screenshot 2026-03-16 at 23 57 25

https://github.com/apache/spark/actions/runs/23180660599/job/67352803326

801.6 Error in devtools::install_version("pkgdown", version = "2.0.1", repos = "https://cloud.r-project.org/") : 
801.6   The package "remotes" is required.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Recover the CIs.

Was this patch authored or co-authored using generative AI tooling?

Generated-by: Claude Code (claude-opus-4-6)

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-56025][INFRA] Install remotes R package for spark-test-image/lint/Dockerfile [SPARK-56025][INFRA] Install remotes R package for spark-test-image/lint/Dockerfile Mar 17, 2026
LABEL org.opencontainers.image.version=""

ENV FULL_REFRESH_DATE=20260210
ENV FULL_REFRESH_DATE=20260316
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is bumped in order to make it sure to rebuild all freshly.

@sarutak
Copy link
Copy Markdown
Member

sarutak commented Mar 17, 2026

@dongjoon-hyun
We recently hit this issue on our CI pipeline. The solution was upgrading roxygen2 to 7.3.3.

@dongjoon-hyun
Copy link
Copy Markdown
Member Author

Thank you. Could you make an independent PR, @sarutak ? I hope we can recover the CI in any way. We can try concurrently.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-56025][INFRA] Install remotes R package for spark-test-image/lint/Dockerfile [SPARK-56025][INFRA] Install remotes R package for spark-test-image/(lint|docs)/Dockerfile Mar 17, 2026
@dongjoon-hyun
Copy link
Copy Markdown
Member Author

If someone recovers the CI, we can close this one.

@dongjoon-hyun dongjoon-hyun marked this pull request as draft March 17, 2026 07:02
@sarutak
Copy link
Copy Markdown
Member

sarutak commented Mar 17, 2026

Thank you. Could you make an independent PR, @sarutak ? I hope we can recover the CI in any way. We can try concurrently.

OK, I've opened a PR with another approach (#54855).
But let's see if this PR can fix the issue.

@dongjoon-hyun
Copy link
Copy Markdown
Member Author

Thank you, @sarutak !

@dongjoon-hyun
Copy link
Copy Markdown
Member Author

To @sarutak , this PR recovered the CIs for both.

Screenshot 2026-03-17 at 00 38 48

I'm monitoring the next step, sparkr.

@sarutak
Copy link
Copy Markdown
Member

sarutak commented Mar 17, 2026

@dongjoon-hyun
roxygen2 7.3.3 seems used even in this PR.
https://github.com/dongjoon-hyun/spark/actions/runs/23182231424/job/67357670225#step:10:3657

So, I'll close my PR.

@dongjoon-hyun
Copy link
Copy Markdown
Member Author

Got it~

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-56025][INFRA] Install remotes R package for spark-test-image/(lint|docs)/Dockerfile [SPARK-56025][INFRA] Install remotes R package for spark-test-image/(lint|docs|sparkr)/Dockerfile Mar 17, 2026
@sarutak
Copy link
Copy Markdown
Member

sarutak commented Mar 17, 2026

@dongjoon-hyun
Copy link
Copy Markdown
Member Author

dongjoon-hyun commented Mar 17, 2026

Ya, I agree with you. I just want to keep them separately because CI recovery is only the first step. We may need to spend more time for the investigation the actual version of Roxygen and others. The current SparkR environment seems messy because it's abandoned for a long time.

This PR only aims to recover PR builder and commit builder on the master branch. All the other daily CIs or release branches and spark-rm release script should be handled carefully one by one.

@sarutak
Copy link
Copy Markdown
Member

sarutak commented Mar 17, 2026

I have no idea why just upgrading roxygen2 in our CI environment addressed the issue but the setting is different from GA workflow, which might cause the difference.

@dongjoon-hyun
Copy link
Copy Markdown
Member Author

Thank you, @LuciferYang and @sarutak .

Copy link
Copy Markdown
Member

@sarutak sarutak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if GA passes.

Copy link
Copy Markdown
Member

@sarutak sarutak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GA passed. Merging to master.
Thank you @dongjoon-hyun and @LuciferYang !

@sarutak sarutak closed this in 54164e9 Mar 17, 2026
@dongjoon-hyun
Copy link
Copy Markdown
Member Author

Thank you, @sarutak and @LuciferYang !

@dongjoon-hyun dongjoon-hyun deleted the SPARK-56025 branch March 17, 2026 14:51
dongjoon-hyun added a commit that referenced this pull request Mar 17, 2026
…e/(lint|docs|sparkr)/Dockerfile`

This PR aims to recover the CI by installing `remotes` R package for the following Dockerfiles.

- dev/spark-test-image/lint/Dockerfile
- dev/spark-test-image/docs/Dockerfile
- dev/spark-test-image/sparkr/Dockerfile

Currently, `master` branch is broken due to the new `devtools` 2.5.0 release. This PR aims to installation `remotes` package explicitly because we cannot pin `devtools` itself.

- https://github.com/r-lib/devtools/releases/tag/v2.5.0 (2026-03-16)

<img width="754" height="263" alt="Screenshot 2026-03-16 at 23 57 25" src="https://github.com/user-attachments/assets/c5b927a4-fe02-490a-866d-1f43460499f2" />

https://github.com/apache/spark/actions/runs/23180660599/job/67352803326

```
801.6 Error in devtools::install_version("pkgdown", version = "2.0.1", repos = "https://cloud.r-project.org/") :
801.6   The package "remotes" is required.
```

No.

Recover the CIs.

Generated-by: Claude Code (claude-opus-4-6)

Closes #54853 from dongjoon-hyun/SPARK-56025.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Kousuke Saruta <[email protected]>
(cherry picked from commit 54164e9)
Signed-off-by: Dongjoon Hyun <[email protected]>
@dongjoon-hyun
Copy link
Copy Markdown
Member Author

I backported this to branch-4.1 to recover branch-4.1 CI.

dongjoon-hyun added a commit that referenced this pull request Mar 17, 2026
…e/(lint|docs|sparkr)/Dockerfile`

This PR aims to recover the CI by installing `remotes` R package for the following Dockerfiles.

- dev/spark-test-image/lint/Dockerfile
- dev/spark-test-image/docs/Dockerfile
- dev/spark-test-image/sparkr/Dockerfile

Currently, `master` branch is broken due to the new `devtools` 2.5.0 release. This PR aims to installation `remotes` package explicitly because we cannot pin `devtools` itself.

- https://github.com/r-lib/devtools/releases/tag/v2.5.0 (2026-03-16)

<img width="754" height="263" alt="Screenshot 2026-03-16 at 23 57 25" src="https://github.com/user-attachments/assets/c5b927a4-fe02-490a-866d-1f43460499f2" />

https://github.com/apache/spark/actions/runs/23180660599/job/67352803326

```
801.6 Error in devtools::install_version("pkgdown", version = "2.0.1", repos = "https://cloud.r-project.org/") :
801.6   The package "remotes" is required.
```

No.

Recover the CIs.

Generated-by: Claude Code (claude-opus-4-6)

Closes #54853 from dongjoon-hyun/SPARK-56025.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Kousuke Saruta <[email protected]>
(cherry picked from commit 54164e9)
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit 8551960)
Signed-off-by: Dongjoon Hyun <[email protected]>
@dongjoon-hyun
Copy link
Copy Markdown
Member Author

This is backported to branch-4.0 too.

HyukjinKwon added a commit that referenced this pull request Apr 6, 2026
### What changes were proposed in this pull request?

See #54872 and #54853

### Why are the changes needed?

See #54872 and #54853

### Does this PR introduce _any_ user-facing change?

No, dev-only.

### How was this patch tested?

I am testing it in my fork. see https://github.com/HyukjinKwon/spark/actions/runs/24021551482/job/70051292787

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #55217 from HyukjinKwon/SPARK-56363.

Authored-by: Hyukjin Kwon <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
HyukjinKwon added a commit that referenced this pull request Apr 6, 2026
### What changes were proposed in this pull request?

See #54872 and #54853

### Why are the changes needed?

See #54872 and #54853

### Does this PR introduce _any_ user-facing change?

No, dev-only.

### How was this patch tested?

I am testing it in my fork. see https://github.com/HyukjinKwon/spark/actions/runs/24021551482/job/70051292787

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #55217 from HyukjinKwon/SPARK-56363.

Authored-by: Hyukjin Kwon <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
(cherry picked from commit 3fb32fd)
Signed-off-by: Hyukjin Kwon <[email protected]>
HyukjinKwon added a commit that referenced this pull request Apr 6, 2026
### What changes were proposed in this pull request?

See #54872 and #54853

### Why are the changes needed?

See #54872 and #54853

### Does this PR introduce _any_ user-facing change?

No, dev-only.

### How was this patch tested?

I am testing it in my fork. see https://github.com/HyukjinKwon/spark/actions/runs/24021551482/job/70051292787

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #55217 from HyukjinKwon/SPARK-56363.

Authored-by: Hyukjin Kwon <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
(cherry picked from commit 3fb32fd)
Signed-off-by: Hyukjin Kwon <[email protected]>
HyukjinKwon added a commit that referenced this pull request Apr 6, 2026
### What changes were proposed in this pull request?

See #54872 and #54853

### Why are the changes needed?

See #54872 and #54853

### Does this PR introduce _any_ user-facing change?

No, dev-only.

### How was this patch tested?

I am testing it in my fork. see https://github.com/HyukjinKwon/spark/actions/runs/24021551482/job/70051292787

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #55217 from HyukjinKwon/SPARK-56363.

Authored-by: Hyukjin Kwon <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
(cherry picked from commit 3fb32fd)
Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants