WebSocketTransport.send completionHandler is called in non escaping manner in case of error

[RolandasRazma]

Bug report

apollo-ios/Sources/ApolloWebSocket/WebSocketTransport.swift

Line 364 in 185d6b7

completionHandler(.failure(error))

completionHandler is called in non escaping manner in case of error

Versions

Please fill in the versions you're currently using:

• apollo-ios SDK version: 0.36.0

[designatednerd]

Do you mean it's not called on the callback queue?

[RolandasRazma]

Was thinking about @escaping but yes, calling it on callback cue would fix that

[designatednerd]

It's declared as @escaping here - declaring escaping does not require it to escape, though.

[RolandasRazma]

sure, but it might break flow depending on what's happening internally

WebSocketTransport.send {
   print("a")
}

print("b")

what order will be output depends on internal state and that's not great.

In any case, closing as #1507 fixes it