Network Rearchitecture#1341
Merged
designatednerd merged 109 commits intobetas/networking-stackfrom Sep 11, 2020
Merged
Conversation
designatednerd
force-pushed
the
explore/interceptors
branch
2 times, most recently
from
6172015 to
df6024d
Compare
designatednerd
force-pushed
the
explore/interceptors
branch
4 times, most recently
from
91c9c47 to
0bde055
Compare
designatednerd
force-pushed
the
explore/interceptors
branch
2 times, most recently
from
6af46dc to
515b1db
Compare
amadeu01
reviewed
Aug 26, 2020
amadeu01
reviewed
Aug 26, 2020
| import Foundation | ||
|
|
||
| /// An error interceptor called to allow further examination of error data when an error occurs in the chain. | ||
| public protocol ApolloErrorInterceptor { |
There was a problem hiding this comment.
I'm not sure if it would work, but what do you think of instead using protocol for this interceptor, actually, use just a function. For instance,
typealias ApolloErrorInterceptor = (Error,
RequestChain,
HTTPRequest<Operation>,
HTTPResponse<Operation>?,
@escaping (Result<GraphQLResult<Operation.Data>, Error>) -> Void)) -> Void
Contributor
Author
There was a problem hiding this comment.
I would wayyyyyy rather have this as a protocol, particularly since it gives longer term flexibility to add more methods if needed.
amadeu01
reviewed
Aug 26, 2020
designatednerd
force-pushed
the
explore/interceptors
branch
4 times, most recently
from
af574ef to
1dd71de
Compare
designatednerd
commented
Sep 3, 2020
| extension GraphQLResult where Data: Decodable { | ||
|
|
||
| public init<T: FlexibleDecoder>(from data: Foundation.Data, decoder: T) throws { | ||
| // SWIFT CODEGEN: fix this to handle codable better |
Contributor
Author
There was a problem hiding this comment.
Thoroughly punting on this for now.
Contributor
Author
|
A preview of the updated networking setup instructions can be found here. Going to be updating the tutorial portion dealing with these changes before cutting a beta. Would love feedback! |
designatednerd
changed the title
This was referenced Sep 9, 2020
designatednerd
force-pushed
the
explore/interceptors
branch
from
ca3b14d to
385be42
Compare
…dedupe callbacks for the watcher.
…entifier for watcher context vs identifier for actual URLSessionTask
…lo store subscriber for future reference
… retry interceptor
… with request chain
designatednerd
force-pushed
the
explore/interceptors
branch
from
385be42 to
38135ee
Compare
designatednerd
changed the title
Contributor
Author
|
OK, pointing this at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR relates to the RFC for the new networking stack - this branch is basically where I've been doing explorations thus far.