Make response parsing helpers public#1372
Merged
designatednerd merged 1 commit intoapollographql:mainfrom Aug 31, 2020
Merged
Conversation
Contributor
|
Definitely making |
Contributor
Author
|
Would be nice, but no not urgent if a new networking stack is coming soon |
Contributor
Contributor
|
Actually, I'm going to go ahead and merge this - there's no reason this has to wait on the new stack. |
Contributor
Author
|
@designatednerd That new networking stack PR draft is looking good to me btw! One of the main reasons we've needed a custom |
Contributor
|
Sweet, yeah that's the idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When extending the functionality of Apollo to perform custom logging or other behavior on requests, these functions would be useful to have access to. In particular, making
parseResultFast()public enablesdecodeto remain internal while still giving users the ability to parse GraphQL responses. MakingparseErrorsOnlyFast()is less significant, however it still would be helpful to centralize the hardcoding of the "errors" key to this one function rather than hardcoding it in both the Apollo codebase and Apollo users' codebases.