Don't allow multiple cancels on RequestChain#1679
Merged
designatednerd merged 1 commit intoapollographql:mainfrom Feb 22, 2021
getfiit:dont_allow_multiple_cancel_on_requestcahin
Merged
Don't allow multiple cancels on RequestChain#1679designatednerd merged 1 commit intoapollographql:mainfrom getfiit:dont_allow_multiple_cancel_on_requestcahin
designatednerd merged 1 commit intoapollographql:mainfrom
getfiit:dont_allow_multiple_cancel_on_requestcahin
Conversation
designatednerd
approved these changes
Feb 22, 2021
Contributor
designatednerd
left a comment
designatednerd
left a comment
There was a problem hiding this comment.
Seems like a reasonable change!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm seeing some crashes in canceling interceptors. It's probably not
RequestChainproblem, but I see no reason why you should be able to cancel it multiple times.