Skip to content

Don't allow multiple cancels on RequestChain #1679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
designatednerd merged 1 commit into from
Feb 22, 2021
Merged

Don't allow multiple cancels on RequestChain #1679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Sources/Apollo/RequestChain.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,11 @@ public class RequestChain: Cancellable {

/// Cancels the entire chain of interceptors.
public func cancel() {
guard self.isNotCancelled else {
// Do not proceed, this chain has been cancelled.
return
}

self.isCancelled.mutate { $0 = true }

// If an interceptor adheres to `Cancellable`, it should have its in-flight work cancelled as well.
Expand Down
⚡