Update documentation to show how to use new delegates and cache policy#618
Merged
designatednerd merged 6 commits intomasterfrom Jul 11, 2019
Merged
Update documentation to show how to use new delegates and cache policy#618designatednerd merged 6 commits intomasterfrom
designatednerd merged 6 commits intomasterfrom
Conversation
| ```swift | ||
| let apollo = ApolloClient(url: URL(string: "http://localhost:8080/graphql")!) | ||
| class Apollo { | ||
| static let shared = Apollo() |
Contributor
There was a problem hiding this comment.
Is a singleton class really needed? What is the benefit over a global variable?
Contributor
There was a problem hiding this comment.
Ah, too fast, I see the example below with the delegate implementations.
Contributor
Author
There was a problem hiding this comment.
Yeah that plus I'm very much team "If you're gonna use a singleton, use a singleton. Don't use the App Delegate as a pseudo-singleton as that's not what it's for."
…p Delegate for the basic setup
…kTransportDelegate` and other advanced usages.
designatednerd
force-pushed
the
add/docs-on-a-plane
branch
from
4f7d52f to
40b7724
Compare
Contributor
Author
|
Also removed old link to CocoaDocs (which is dead) and fixed some stray whitespace in the iOS build script. |
This was referenced Jul 11, 2019
Contributor
Author
|
I guess this is an approval?
😃 Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR:
HTTPTransportClientDelegatethat came out with v0.11.0fetching-queries.mdto include information about usingGETfor queries and add the most recent cache policy addition.