formatResponse: Fix typings and provide full request context.#3431
Merged
Conversation
Previously, this was only typed as a `Function`, which means we lost all the typings on the return side of that method.
Comment on lines
-388
to
+391
| { | ||
| context: requestContext.context, | ||
| }, | ||
| requestContext, |
Contributor
There was a problem hiding this comment.
Well that was easy 😄I read the PR and thought - "how's he gonna get out of that breaking change?" Interesting and convenient that this was passed in as an object before!
trevor-scheer
approved these changes
Oct 22, 2019
glasser
added a commit
that referenced
this pull request
Apr 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the
formatResponsewas only typed as aFunction. However, since it's expected that the function return aGraphQLResponse(the same thing that it receives, that typing seems a bit too generic. This changes the typing to more accurately reflect the way it should be used, and also provides it the completerequestContextrather than just the cherry-pickedcontextproperty.