Fix formatResponse typings#5089
Merged
Merged
Conversation
glasser
force-pushed
the
glasser/formatresponse-typings
branch
from
fd9ef3d to
e79c8d9
Compare
This was referenced Apr 6, 2021
glasser
force-pushed
the
glasser/formatresponse-typings
branch
from
e79c8d9 to
9825c40
Compare
Member
Author
|
I've released a prerelease with this fix, version |
Member
Author
|
This is released in Apollo Server 2.23.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This typing was added in #3431; it looks like we put the
| nullin the wrongplace. Fortunately, a function that's OK with accepting a null argument and will
never return null can still typecheck with the new type.
Fixes #5009.