VSCode: Multiple local schema files validation problem in 1.10.0

[typhoon2k]

Intended outcome:

In our project we are using multiple schema files. As per recommendations for this scenario our apollo.config.js looks approximately the following:

module.exports = {
    client: {
        service: {
            name: "blabla-api",
            localSchemaFile: "./src/graphql/schema/blabla-api.graphql"
        },
        includes: [
            "**/src/graphql/schema/blabla-this-api.graphql",
            "**/src/graphql/schema/blabla-that-api.graphql",
            "**/src/graphql/operations/**/*.graphql"
        ]
    }
};

Until version 1.10.0 we didn't had any problems with this configuration - syntax highlighting and code completion was working fine.

Actual outcome:

After update to 1.10.0 we are getting "Local field ... must have a @client directive" validation exceptions in all operation graphql files, which are using fields defined in schema extension files blabla-this-api.graphql and blabla-that-api.graphql.

How to reproduce the issue:

Create similar setup with multiple local schema files.

Versions

1.10.0

[JakeDawkins]

Hi @typhoon2k! Thanks for bringing this up, it's definitely an issue.

The language server is looking toward the includes in client project to make an assumption that those schema files are client schema files, which isn't the case for you.

I know I have recommended using includes to handle multiple schema files in the past, so I'm working to find a solution (like multiple localSchemaFiles or otherwise). Until then, you can downgrade the extension in vs code by going to the extensions pane, right clicking the apollo extension and installing a previous version (like 1.9.2).

I'll keep this up-to-date with any updates to the progress for fixing this!

[JakeDawkins]

Just opened a PR (#1500) which should resolve this issue after review. I may expand on it and add the ability to support globs as well as filePaths, but that's where it's at now!