Support multiple schema files with localSchemaFile#1500
Merged
JakeDawkins merged 7 commits intomasterfrom Sep 12, 2019
Merged
Conversation
7bb1869 to
a3c3880
Compare
Affected commands: - cilent:codegen - service:check - service:push
e0e2d41 to
d6837ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1483
What
The purpose of this PR is to officially support multiple schema files through the
localSchemaFileconfig option and CLI flag for the client and service commands.Why
Until VSCode 1.10.0 (and accompanying CLI release), I've been recommending people use the
client.includesoption to allow for multiple schema files when needed. Since clientincludesnow is treated as a client schema for the purpose of autocompleting client fields (#1433) this no longer works.How
This PR overloads the existing
localSchemaFileoption, allowing for a list of filepaths (in the config file) or multiple uses of the--localSchemaFileflag (in the CLI).The schema loader will go through the same process it used to in order to load a schema from a file, with a couple modifications.
Questions
extendSchemainstead to progressively build the schemaextendSchemarather than concatenating SDL?TODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.