Fix Scala codegen emitting fields under names that don't match the schema#1008
Merged
trevor-scheer merged 3 commits intoapollographql:masterfrom Feb 13, 2019
Merged
Conversation
shadaj
force-pushed
the
scala-original-names
branch
4 times, most recently
from
b5740db to
1c51ab4
Compare
shadaj
force-pushed
the
scala-original-names
branch
from
1c51ab4 to
6445987
Compare
shadaj
force-pushed
the
scala-original-names
branch
from
6b0f03d to
9fa2cc3
Compare
trevor-scheer
suggested changes
Feb 13, 2019
Contributor
trevor-scheer
left a comment
trevor-scheer
left a comment
There was a problem hiding this comment.
LGTM, just want to fix the any typings and this is good to go!
shadaj
force-pushed
the
scala-original-names
branch
from
157a5dc to
915d070
Compare
Contributor
|
Thanks @shadaj! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an oversight in the trait rewrite, since variable names in the generated traits determine the JS object that will be sent to Apollo but those variable names are transformed versions of the schema names, so there could be mismatches. This PR annotates the variables to tell Scala.js to emit those variables under the original schema names.
This can be included in a patch release, it doesn't have any breaking changes.