Skip to content

Delete federated service#1192

Merged
JakeDawkins merged 2 commits intorelease-federationfrom
jake/service-delete
Apr 16, 2019
Merged

Delete federated service#1192
JakeDawkins merged 2 commits intorelease-federationfrom
jake/service-delete

Conversation

@JakeDawkins
Copy link
Copy Markdown
Contributor

@JakeDawkins JakeDawkins commented Apr 15, 2019

  • Adds a service:delete command for federated services only

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

@JakeDawkins JakeDawkins force-pushed the jake/service-delete branch 2 times, most recently from 08a17d7 to 8db2ff2 Compare April 15, 2019 17:42
@JakeDawkins JakeDawkins marked this pull request as ready for review April 15, 2019 20:29
@JakeDawkins JakeDawkins force-pushed the jake/service-delete branch from 6fdc24d to d546528 Compare April 16, 2019 00:36
@JakeDawkins JakeDawkins force-pushed the jake/service-delete branch from 712e89a to beb8756 Compare April 16, 2019 00:56
@JakeDawkins JakeDawkins merged commit ef71e96 into release-federation Apr 16, 2019
@JakeDawkins JakeDawkins deleted the jake/service-delete branch April 16, 2019 01:01
trevor-scheer pushed a commit that referenced this pull request May 9, 2019
* Add service delete command and mutation

* update checks operation to match new schema
trevor-scheer pushed a commit that referenced this pull request May 9, 2019
* Add service delete command and mutation

* update checks operation to match new schema
trevor-scheer pushed a commit that referenced this pull request May 9, 2019
* Add service delete command and mutation

* update checks operation to match new schema
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant