Skip to content

Append terminating newline to output#1226

Merged
trevor-scheer merged 1 commit intoapollographql:masterfrom
michaelnisi:ios-531
Jul 12, 2019
Merged

Append terminating newline to output#1226
trevor-scheer merged 1 commit intoapollographql:masterfrom
michaelnisi:ios-531

Conversation

@michaelnisi
Copy link
Copy Markdown
Contributor

Xcode expects newline terminated files as noted in apollographql/apollo-ios#531. I found this related PR #525, so maybe a more generic solution should be considered.

This is my first contribution to this project, let alone my first lines of TypeScript, but I hope its intention comes across.

@designatednerd
Copy link
Copy Markdown
Contributor

@michaelnisi mind updating this to fix the merge conflicts? I'm not entirely clear on why some builds failed, but let's see if they do again 😆

@michaelnisi
Copy link
Copy Markdown
Contributor Author

Rebased. Failing checks seem unrelated.

@michaelnisi
Copy link
Copy Markdown
Contributor Author

michaelnisi commented Jul 11, 2019

@designatednerd Skimming through the test logs… When was the last time those tests passed? 😟

@designatednerd
Copy link
Copy Markdown
Contributor

I...don't know. I'll ping the tools team when they're up in 🇺🇸

@trevor-scheer
Copy link
Copy Markdown
Contributor

@designatednerd tests are notoriously flaky on this repo, often resolved by the first re-run 😕, the current azure node 10 test that's failing is new to me, but I can't reproduce locally and it's not happening in the other environments. Sad to say it, but let's disregard that failure for now.

@trevor-scheer trevor-scheer added 🐦 component - swift 🤖 component - codegen related to the codegen core packages labels Jul 12, 2019
@trevor-scheer trevor-scheer requested review from designatednerd and removed request for jbaxleyiii and trevor-scheer July 12, 2019 18:30
Copy link
Copy Markdown
Contributor

@designatednerd designatednerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swift stuff is good, would appreciate someone who knows typescript taking a 2nd look!

@trevor-scheer trevor-scheer merged commit 916ce59 into apollographql:master Jul 12, 2019
@michaelnisi michaelnisi deleted the ios-531 branch July 13, 2019 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐦 component - swift 🤖 component - codegen related to the codegen core packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants