Skip to content

Graph Composition ID included in targetURL#1401

Merged
mayakoneval merged 4 commits intomasterfrom
mkoneval/add-graph-composition-id
Jul 15, 2019
Merged

Graph Composition ID included in targetURL#1401
mayakoneval merged 4 commits intomasterfrom
mkoneval/add-graph-composition-id

Conversation

@mayakoneval
Copy link
Copy Markdown
Contributor

@mayakoneval mayakoneval commented Jul 15, 2019

add the graph composition id to the returned url from the cli so the UI can add service name

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

@mayakoneval mayakoneval force-pushed the mkoneval/add-graph-composition-id branch from c7960a1 to cde3282 Compare July 15, 2019 18:26
Copy link
Copy Markdown
Contributor

@trevor-scheer trevor-scheer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mayakoneval
Copy link
Copy Markdown
Contributor Author

LGTM!

request to add tests for the formatHumanReadable formatMarkdown etc

@mayakoneval mayakoneval force-pushed the mkoneval/add-graph-composition-id branch from 7dd00a9 to c4f9e9e Compare July 15, 2019 21:50
@mayakoneval mayakoneval merged commit 26d6904 into master Jul 15, 2019
@mayakoneval mayakoneval deleted the mkoneval/add-graph-composition-id branch July 15, 2019 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants