Make duplicate operations error a failing error#1812
Merged
JakeDawkins merged 3 commits intomasterfrom Feb 26, 2020
Merged
Conversation
mgeraci
approved these changes
Feb 24, 2020
mgeraci
left a comment
There was a problem hiding this comment.
So moving contents/documents/documentDidChange out of the try block causes the whole command to exit with an error? That's perfect!
Contributor
Author
|
I believe this is good to go, so I'm gonna give it a merge and minor release. I tested manually with client:push and client:check and verified it failed both before trying to actually run the operation (which is what we want). I think this error could be cleaned up (as right now it's a very unfriendly format when it's output), potentially even as a step on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix an issue where some users are pushing client code that errors because the error notifying users of duplicate client operation names doesn't exit appropriately.
the previous error, just told users that duplicate operations aren't permitted in client projects, but never actually enforced that as it should have. This PR should fix that behavior.
TODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.