Skip to content

Make duplicate operations error a failing error #1812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JakeDawkins merged 3 commits into from
Feb 26, 2020
Merged

Make duplicate operations error a failing error #1812

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
790c94c
removed the catch block preventing proper exit
JakeDawkins Feb 24, 2020
dc5382f
change error message to indicate error not warning
JakeDawkins Feb 24, 2020
532190f
update changelog
JakeDawkins Feb 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions packages/apollo-language-server/src/project/base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,13 +197,9 @@ export abstract class GraphQLProject implements GraphQLSchemaProvider {
// Don't process files of an unsupported filetype
if (!languageId) return;

try {
const contents = readFileSync(filePath, "utf8");
const document = TextDocument.create(uri, languageId, -1, contents);
this.documentDidChange(document);
} catch (error) {
console.error(error);
}
const contents = readFileSync(filePath, "utf8");
const document = TextDocument.create(uri, languageId, -1, contents);
this.documentDidChange(document);
}

fileWasDeleted(uri: DocumentUri) {
Expand Down Expand Up @@ -233,7 +229,7 @@ export abstract class GraphQLProject implements GraphQLSchemaProvider {
if (definition.kind === Kind.OPERATION_DEFINITION && definition.name) {
if (operations[definition.name.value]) {
throw new Error(
`️️There are multiple definitions for the ${definition.name.value} operation. All operations in a project must have unique names. If generating types, only the types for the first definition found will be generated.`
`️️There are multiple definitions for the \`${definition.name.value}\` operation. Please rename or remove all operations with the duplicated name before continuing.`
);
}
operations[definition.name.value] = definition;
Expand Down
⚡