[AR-1691] The CLI does not need to know the frontend URL#1990
Merged
Conversation
Currently the CLI has configuration (via `engine.frontend` in a config file or the --frontend flag to a few commands) to control what Engine frontend the user is using. This is primarily set by Apollo employees using staging servers. This is in addition to setting `engine.endpoint` to control which GraphQL server it talks to. This is used for two things: - passing arguments to a couple ServiceMutation fields - printing links in `services:list` As of recently, this no longer is needed: - those ServiceMutation fields now ignore the `frontend` argument and just use the correct frontend for the server processing them - we expose a Query.frontendUrlRoot field that `services:list` can use So this change completely removes recognition of this config field as well as the flag. (Note that it is not an error to have unrecognized fields in your config file, though it is to pass an unknown flag.) While this is technically backwards-incompatible, we don't expect that this undocumented feature is used much other than by Apollo employees.
5ea4dac to
03f3349
Compare
jbaxleyiii
approved these changes
Jun 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the CLI has configuration (via
engine.frontendin a config file orthe --frontend flag to a few commands) to control what Engine frontend the user
is using. This is primarily set by Apollo employees using staging servers. This
is in addition to setting
engine.endpointto control which GraphQL server ittalks to.
This is used for two things:
services:listAs of recently, this no longer is needed:
frontendargument and just usethe correct frontend for the server processing them
services:listcan useSo this change completely removes recognition of this config field as well as
the flag. (Note that it is not an error to have unrecognized fields in your
config file, though it is to pass an unknown flag.) While this is technically
backwards-incompatible, we don't expect that this undocumented feature is used
much other than by Apollo employees.
TODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.