fix(apollo-graphql): Preserve directive usages on SchemaDefinition nodes#2457
Merged
trevor-scheer merged 5 commits intoapollographql:masterfrom Nov 3, 2021
Merged
Conversation
This was referenced Oct 15, 2021
Merged
trevor-scheer
force-pushed
the
schema-directives
branch
from
6a513dd to
8240c2c
Compare
updates buildSchemaFromSDL to pass through applied directives on the `schema` definition node.
trevor-scheer
force-pushed
the
schema-directives
branch
from
8240c2c to
8aed177
Compare
trevor-scheer
changed the title
trevor-scheer
pushed a commit
to lennyburdette/federation
that referenced
this pull request
Nov 20, 2021
This requires a change to apollo-graphql as well: apollographql/apollo-tooling#2457
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updates buildSchemaFromSDL to pass through applied directives on the
schemadefinition node.TODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.