fix(subgraph): support @contact directive in printSubgraphSchema#1096
Merged
trevor-scheer merged 9 commits intoapollographql:version-0.xfrom Nov 20, 2021
Merged
Conversation
trevor-scheer
force-pushed
the
schema-directives
branch
2 times, most recently
from
53b0b88 to
92fcec5
Compare
trevor-scheer
changed the title
@contact directive in printSubgraphSchema
glasser
reviewed
Nov 4, 2021
Contributor
Author
|
New directive buckets and comments are very clear and helpful! |
glasser
approved these changes
Nov 20, 2021
Member
glasser
left a comment
glasser
left a comment
There was a problem hiding this comment.
Thanks for taking the suggestion I sent you in Slack! I think this is a lot easier to wrap my head around.
This requires a change to apollo-graphql as well: apollographql/apollo-tooling#2457
how they're used and how they end up in the schema. Break dependency of supergraph printing from list exported by subgraph package since this dependency doesn't really make sense. The supergraph should know internally what it supports and how it should print.
trevor-scheer
force-pushed
the
schema-directives
branch
from
7d2cc8b to
78d6413
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Print
@contactdirective on schema nodes from theprintSubgraphSchemafunctionFixes #1094