Fix edge case when no config is provided#734
Merged
trevor-scheer merged 1 commit intomasterfrom Nov 21, 2018
Merged
Conversation
When no config is provided, the URI is resolved to the _parent_ directory because we're not handling that case correctly. To resolve this, the URI should be set to the filepath itself.
martijnwalraven
approved these changes
Nov 21, 2018
Contributor
martijnwalraven
left a comment
martijnwalraven
left a comment
There was a problem hiding this comment.
I don't have the complete context and there might be a more principled way to deal with this, but I think this makes sense as a fix for now.
|
@trevor-scheer release 2.1.3 worked perfectly for me. 87 files generated across my 3 graphql folders. Bless you sir. Happy Holidays! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no config is provided, the URI is resolved to the parent directory because we're not handling that case correctly.
To resolve this, the URI should be set to the filepath itself.
The manifestation of the issue can be seen in the screenshot below. In the current state, we're taking the
.dir, which is undesirable whenfilePathpoints to the root of the project.