Skip to content

Fix edge case when no config is provided #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trevor-scheer merged 1 commit into from
Nov 21, 2018
Merged

Fix edge case when no config is provided #734

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/apollo/src/Command.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,14 @@ export abstract class ProjectCommand extends Command {
flags: Flags
) {
const loadingHandler = new OclifLoadingHandler(this);
const rootURI = `file://${parse(filepath).dir}`;

// When no config is provided, filepath === process.cwd()
// In this case, we don't want to look to the .dir since that's the parent
const rootURI =
filepath === process.cwd()
? `file://${filepath}`
: `file://${parse(filepath).dir}`;

const clientIdentity = {
name: "Apollo CLI",
version,
Expand Down
⚡