Skip to content

fix: Delete screen recording after serving.#300

Closed
kkb912002 wants to merge 1 commit intoappium:masterfrom
kkb912002:feature/delete-screen-record-after-serve
Closed

fix: Delete screen recording after serving.#300
kkb912002 wants to merge 1 commit intoappium:masterfrom
kkb912002:feature/delete-screen-record-after-serve

Conversation

@kkb912002
Copy link
Copy Markdown

It seems that the video file deletion was missed when the screen recording was properly terminated.

@mykola-mokhnach
Copy link
Copy Markdown

The driver is configured to cleanup the recorded video upon stopping the session:

await this._screenRecorder?.stop(true);

The recorded file is kept for the duration of the session, so one could download it repeatedly if necessary

@kkb912002
Copy link
Copy Markdown
Author

The driver is configured to cleanup the recorded video upon stopping the session:

await this._screenRecorder?.stop(true);

The recorded file is kept for the duration of the session, so one could download it repeatedly if necessary

Ah, to be precise, when recording screen multiple times with interruptions, only the last recorded file gets deleted, while the previously recorded files all remain in the temporary directory.

@kkb912002
Copy link
Copy Markdown
Author

delete it only when start new recording: #302

@kkb912002 kkb912002 closed this Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants