Skip to content

fix: Clearing previous recorded video if start new one.#302

Merged
KazuCocoa merged 2 commits intoappium:masterfrom
kkb912002:feature/delete-existing-screen-record-before-start
Mar 5, 2025
Merged

fix: Clearing previous recorded video if start new one.#302
KazuCocoa merged 2 commits intoappium:masterfrom
kkb912002:feature/delete-existing-screen-record-before-start

Conversation

@kkb912002
Copy link
Copy Markdown

when recording screen multiple times, only the last recorded file gets deleted, while the previously recorded files all remain in the temporary directory.

@kkb912002 kkb912002 changed the title feat: clearing previous recorded video if start new one. fix: clearing previous recorded video if start new one. Mar 4, 2025
@kkb912002 kkb912002 changed the title fix: clearing previous recorded video if start new one. fix: Clearing previous recorded video if start new one. Mar 5, 2025
Comment thread lib/commands/record-screen.js Outdated
this.log.debug('Forcing the active screen recording to stop');
await this._screenRecorder.stop(true);
} else if (this._screenRecorder) {
this.log.debug('Clearing previous record');
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearing the recent screen recording

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you.

@KazuCocoa KazuCocoa merged commit d8c8b87 into appium:master Mar 5, 2025
7 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 5, 2025
## [4.2.1](v4.2.0...v4.2.1) (2025-03-05)

### Bug Fixes

* Clearing the recent recorded video if start new one. ([#302](#302)) ([d8c8b87](d8c8b87))
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 5, 2025

🎉 This PR is included in version 4.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@KazuCocoa KazuCocoa added the size:XS contribution size: XS label Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released size:XS contribution size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants