Skip to content

fix: Clearing previous recorded video if start new one. #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KazuCocoa merged 2 commits into from
Mar 5, 2025
Merged

fix: Clearing previous recorded video if start new one. #302

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c16651
clearing previous recorded video if start new one.
kkb912002 Mar 4, 2025
f1ea781
improve log message
kkb912002 Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/commands/record-screen.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,9 @@ export async function startRecordingScreen (
}
this.log.debug('Forcing the active screen recording to stop');
await this._screenRecorder.stop(true);
} else if (this._screenRecorder) {
this.log.debug('Clearing previous record');
Copy link
Copy Markdown

@mykola-mokhnach mykola-mokhnach Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearing the recent screen recording

Copy link
Copy Markdown
Author

@kkb912002 kkb912002 Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you.

await this._screenRecorder.stop(true);
}
this._screenRecorder = null;

Expand Down
⚡