Skip to content

fix: fixing authz messages decoding issue in antehandlers #418

Merged
spoo-bar merged 3 commits into
mainfrom
spoorthi/msg-exec-name
Jul 7, 2023
Merged

fix: fixing authz messages decoding issue in antehandlers #418
spoo-bar merged 3 commits into
mainfrom
spoorthi/msg-exec-name

Conversation

@spoo-bar

@spoo-bar spoo-bar commented Jul 7, 2023

Copy link
Copy Markdown
Contributor

Closes: #417

  • Fixing the incorrect authz msg decoding in the x/rewards ante handlers.
  • Using the nice helper func provided by x/authz to unwrap the msg instead of trying it explicitly

@codecov

codecov Bot commented Jul 7, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.01 ⚠️

Comparison is base (be633fd) 69.39% compared to head (530a0c2) 69.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #418      +/-   ##
==========================================
- Coverage   69.39%   69.39%   -0.01%     
==========================================
  Files          67       67              
  Lines        3977     3976       -1     
==========================================
- Hits         2760     2759       -1     
  Misses       1122     1122              
  Partials       95       95              
Impacted Files Coverage Δ
x/rewards/ante/ante_utils.go 68.75% <50.00%> (-0.95%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@spoo-bar spoo-bar marked this pull request as ready for review July 7, 2023 09:34
@spoo-bar spoo-bar requested review from a team and fdymylja July 7, 2023 09:34

@aelesbao aelesbao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any test covering this bug to avoid regressions?

@spoo-bar spoo-bar requested a review from aelesbao July 7, 2023 10:56
@spoo-bar spoo-bar merged commit ee212ab into main Jul 7, 2023
@spoo-bar spoo-bar deleted the spoorthi/msg-exec-name branch July 7, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: authz MsgExec not working

2 participants