Skip to content

fix: fixing authz messages decoding issue in antehandlers #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spoo-bar merged 3 commits into from
Jul 7, 2023
Merged

fix: fixing authz messages decoding issue in antehandlers #418

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7588c9
fixing authz messages decoding issue
spoo-bar Jul 7, 2023
d1905f5
Update CHANGELOG.md
spoo-bar Jul 7, 2023
530a0c2
adding test for authz decode
spoo-bar Jul 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ Contains all the PRs that improved the code without changing the behaviours.
### Fixed

- [#414](https://github.com/archway-network/archway/pull/414) - Preventing user from setting contract flat fee if rewards address is not set
- [#418](https://github.com/archway-network/archway/pull/418) - Fixing authz msg decoding in x/rewards antehandlers

## [v1.0.1]

Expand Down
14 changes: 7 additions & 7 deletions x/rewards/ante/ante_utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,14 @@ func GetContractFlatFees(ctx sdk.Context, rk RewardsKeeperExpected, codec codec.
}
return nil, true, nil
}
case *authz.MsgExec: // if msg is authz msg, unwrap the msg and check if any are wasmTypes.MsgExecuteContract
case *authz.MsgExec: // if msg is authz msg, get the unwrapped msgs and check if any are wasmTypes.MsgExecuteContract
{
for _, v := range msg.Msgs {
var wrappedMsg sdk.Msg
err := codec.UnpackAny(v, &wrappedMsg)
if err != nil {
return nil, false, sdkErrors.Wrapf(sdkErrors.ErrUnauthorized, "error decoding authz messages")
}
authzMsgs, err := msg.GetMessages()
if err != nil {
return nil, false, sdkErrors.Wrapf(sdkErrors.ErrUnauthorized, "error decoding authz messages")
}

for _, wrappedMsg := range authzMsgs {
cff, hasWasmMsgs, err := GetContractFlatFees(ctx, rk, codec, wrappedMsg)
if err != nil {
return nil, hasWasmMsgs, err
Expand Down
⚡